Unable to update deployment on unreleased cloud template version

an2ane commented 1 year ago

Code of Conduct

This project has a Code of Conduct that all participants are expected to understand and follow:

[x] I have read and agree to the project's Code of Conduct

vRA Version

vRA Cloud in 8.10.1

Terraform Version

Terraform v1.2.6 on windows_amd64

vRA Terraform Provider Version

provider registry.terraform.io/vmware/vra v0.6.0

Affected Resource(s)

vra_deployment

Terraform Configuration Files

data "vra_catalog_item" "vmaas" {
  name = "${var.catalog_item_name_vmaas}"
}

resource "vra_deployment" "vm" {
  name        = "terra-${local.timerand}"
  description = "Generated by Terraform"

  catalog_item_id      = data.vra_catalog_item.vmaas.id
  # catalog_item_version = "0.6.5"
  project_id           = data.vra_project.this.id

  inputs = {
    ...
  }
}

Expected Behavior

The updated values should be taken into account, and the update should be running on the portal, as if the update was launched on the portal. It does work on the vRA portal even though the version is unrealased.

Actual Behavior

There is a call to get the cloud template version, however we get a 404 error even if the catalog item version is set to the deployment version.

vra_deployment.vm: Modifying... [id=some_random_id] ╷ │ Error: [GET /catalog/api/items/{id}/versions/{versionId}][404] getVersionByIdUsingGET2NotFound &{Message:No value present StatusCode:404} │ │ with vra_deployment.vm, │ on vm_deployment.tf line 43, in resource "vra_deployment" "vm": │ 43: resource "vra_deployment" "vm" { │

Steps to Reproduce

Deploy a VM through TF
Update the Cloud Template version on vRA and release it on the Service Broker. Also, unrelease the old version so you only have one version available
Update the TF file with new values (for example, increase the disk size)
Try to add or comment the catalog_item_version with the one used for the previous deployment
Run a terraform apply
See a 404 error (with and without catalog_item_version)

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

an2ane commented 1 year ago

Also, if we put the catalog_item_version as the latest version, then it will destroy then recreate the resource. Not really the behavior we want :)

This might become annoying for our users.

an2ane commented 1 year ago

It was fixed in https://github.com/vmware/terraform-provider-vra/releases/tag/v0.7.3

vmware / terraform-provider-vra