search

vmware / terraform-provider-wavefront

Terraform Wavefront provider
https://www.terraform.io/docs/providers/wavefront/
Mozilla Public License 2.0
8 stars 23 forks source link

Support for Metrics Policy & Various Data Sources #83

Closed ssnorrizaurous closed 2 years ago

ssnorrizaurous commented 2 years ago

Implements https://github.com/vmware/terraform-provider-wavefront/issues/82. PR includes full Metrics Policy Resource implantation/tests/docs and various data source implementations. Please let me know if you'd like to change any approach or naming. Waiting for https://github.com/wavefrontHQ/go-wavefront-management-api/pull/46 to go through before finalizing this PR but early feedback is welcome!

vmwclabot commented 2 years ago

@ssnorrizaurous, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

ssnorrizaurous commented 2 years ago

Another option is to have data sources for users/groups/roles take a query parameter like the api and return a list of matches or all if no query is provided.

keep94 commented 2 years ago

Be sure to rebase to master. I submitted a small PR to fix the linter.

keep94 commented 2 years ago

It looks like there are still lint failures. Generally with go imports, list the go standard packages (the ones that don't start with github.com) alphabetically followed by a blank line followed by all the 3rd party packages (github ones) sorted alphabetically.

vmwclabot commented 2 years ago

@ssnorrizaurous, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.