search

vmware / vic

vSphere Integrated Containers Engine is a container runtime for vSphere.
http://vmware.github.io/vic
Other
639 stars 173 forks source link

VIC Admin cleanup & unit tests #2955

Open gigawhitlocks opened 7 years ago

gigawhitlocks commented 7 years ago

VIC Admin has grown organically since the beginning of VICE and being a minor component has been somewhat neglected; it has become a bit of a spaghetti code monster over time and needs to be reorganized and have interfaces defined such that vSphere operations can be easily mocked out for the sake of unit testing.

The unit tests that exist also need to be audited to make sure they are still relevant, as there are references to features that no longer exist in the tests. More tests will also need to be added to cover the new functionality of the component.

Writing a good test suite for this component will require the reorganization mentioned above, which is why this is debt.

gigawhitlocks commented 7 years ago

We also need to remove the use of Validator in rendering pages that do not need it, e.g. https://github.com/vmware/vic/pull/2883/files#r86441744

hickeng commented 7 years ago

concur - +1 for a structured interface, and clean handling of unavailable/unimplemented portions.

we should be using vcsim for unit test of any portions of vicadmin that require infrastructure interaction.