search

vmware / vic

vSphere Integrated Containers Engine is a container runtime for vSphere.
http://vmware.github.io/vic
Other
640 stars 173 forks source link

Allow vic-machine upgrade to be used as part of daily dev workflow #4337

Open hickeng opened 7 years ago

hickeng commented 7 years ago

Story As a VIC developer I want to be able to easily deploy my freshly built VIC binaries As a VIC developer I want to be exercising core product workflows as part of my dev workflow whenever possible to catch problems

Details Currently the build version is embedded into bin/.iso-base.tgz and is generated from git repo tags. This approach has two problems when applied to a dev environment:

  1. code may not be a commit, let alone align with a repo tag
  2. embedding the version in the iso-base requires a full rebuild/reinstall of the iso packages to change

Possible version inputs for dev environment: a. last commit modifying config structures b. checksum of config structure definitions c. time (using just the raw time implies that the isos would need rebuilding every single make, so some intelligence needs to be applied)

Acceptance A suitable version is embedded in an ISO in a dev environment so that upgrade can be done without --force or environment changes A version increment should only regenerate ISOs, without requiring package installation/update Update bash-helpers.sh with a function that uses upgrade where possible and falls back to delete/create otherwise

hickeng commented 7 years ago

The version is currently injected into xorriso-options.cfg during the initialize_bundle function (isos/base/utils.sh) - this should be moved to the generate_iso function in the same file.

gigawhitlocks commented 7 years ago

@hickeng your link to bash-helpers.sh above is broken