vmware / vmware-aria-operations-integration-sdk

The VMware Aria Operations Integration SDK contains libraries, tools, and documentation for developing Management Packs for VMware Aria Operations. It is intended to make creating a Management Pack simple and fast, while allowing developers to use the language of their choice.
https://vmware.github.io/vmware-aria-operations-integration-sdk/
Apache License 2.0
13 stars 6 forks source link

docker_port is not used to set the port used by the container #241

Closed quirogas closed 11 months ago

quirogas commented 11 months ago

Describe the bug

We currently have the option to specify a docker_port in the config.json file. However, modifying the value does not affect the port where. Looking further at the code, we read the value in the Project object, but we don't use it anywhere. _

Reproduction steps

  1. Change docker_port in config.json file
  2. run mp-test or mp-build (container will run in port 8080 regardless)

Expected behavior

  1. We should allow users to set the docker_port in the global config file.
  2. We should allow users to set the docker port as a parameter when running mp-test and mp-build
  3. we should remove docker_port from the project config.json file to avoid including unnecessary information in git commits.

Additional context

No response