Info level is too chatty for this sleep message, debug is good - Githubissues

vmware / vmware-go-kcl-v2

vmware-go-kcl is a vmware originated open-source project for AWS Kinesis Client Library in Go. It has been widely used by many external companies and internally by Carbon Black. vmware-go-kcl-v2 is its companion project by utilizing AWS Go SDK V2 which introduces lots of breaking changes. To keep the repo clean, it is better to have a separated repo vmware-go-kcl-v2 with better golang project structure improvement.

MIT License

23 stars 17 forks source link

Info level is too chatty for this sleep message, debug is good #41

Closed komealy closed 1 year ago

komealy commented 1 year ago

Having this in Info level produces thousands of messages per minute in a production level stream that is operating appropriately. Knowing this for debug purposes is good enough. We shouldn't be overloading log processing pipelines with this much repetitive spam in info level.

Resolves https://github.com/vmware/vmware-go-kcl-v2/issues/40

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 134ca8d46ee440540c6c6a48aeeab9432bb33b73 has a no-reply/unreachable author email address: 3846175+komealy@users.noreply.github.com

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 9bbe0b862853ccd227b652c45966912423ad6274 has a no-reply/unreachable author email address: 3846175+komealy@users.noreply.github.com

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit b19946ec79f8f00bd1f96fc7007d75e33db68fcd has a no-reply/unreachable author email address: 3846175+komealy@users.noreply.github.com

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit bf3acf9021d60277d350ff1b3b49d59fdd238e45 has a no-reply/unreachable author email address: 3846175+komealy@users.noreply.github.com

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 72c5b4f897670ad8ff82cb5387966f0e67ed5045 has a no-reply/unreachable author email address: 3846175+komealy@users.noreply.github.com

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 9553ec43e21b829b36a5b0300f69a0935646a99d has a no-reply/unreachable author email address: 3846175+komealy@users.noreply.github.com

komealy commented 1 year ago

I tried all the things suggested by Github to allow my real email to be the author of this git commit, but it still only ended up as the noreply email...

komealy commented 1 year ago

Looks like the original commit was the issue, I had to start fresh after setting all my github email settings. Then my email is now the author in the new PR #42