Info level is too chatty for this sleep message, debug is good

vmware / vmware-go-kcl-v2

vmware-go-kcl is a vmware originated open-source project for AWS Kinesis Client Library in Go. It has been widely used by many external companies and internally by Carbon Black. vmware-go-kcl-v2 is its companion project by utilizing AWS Go SDK V2 which introduces lots of breaking changes. To keep the repo clean, it is better to have a separated repo vmware-go-kcl-v2 with better golang project structure improvement.

MIT License

23 stars 17 forks source link

Info level is too chatty for this sleep message, debug is good #42

Closed komealy closed 1 year ago

komealy commented 1 year ago

Having this in Info level produces thousands of messages per minute in a production level stream that is operating appropriately. Knowing this for debug purposes is good enough. We shouldn't be overloading log processing pipelines with this much repetitive spam in info level.

Resolves https://github.com/vmware/vmware-go-kcl-v2/issues/40

vmwclabot commented 1 year ago

@komealy, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit e1961490be2d343706e15a2fcf4b92f048e18c8b must be signed by komealy@hotmail.com

komealy commented 1 year ago

Also refactoring to satisfy go-staticcheck

komealy commented 1 year ago

Sorry for all the retries, I wanted a clean PR in #43