Closed qiuminwei closed 5 years ago
Hi @kunal-pmj
How about extracting host as input parameter?
Hi @kunal-pmj
How about extracting host as input parameter?
You mean using the input parameter 'vc' as host?
That way the generated doc will carry VC hostname/Ip.
@jrgarcia can you provide inputs on this?
Thanks Kunal
No, I mean adding a new parameter ‘--host’, I sent a review before but canceled it.
By the new input parameter you can replace the host with the real hostname/IP, or use the default value( <vcenter>
) if you just want to generate the document.
I would be ok with adding another parameter to pass in host information. The thing I was trying to avoid by using <vcenter>
was generating a binding from this that sets a host that no one could reach. I thought about using vcenter.example.com
and then localhost
, but I wanted a default that would fail fast (<vcenter>
isn't valid) and wouldn't lead users to believe that there was a public host available.
Hi @qiuminwei
removing from the host would reintroduce following issue which was addressed by this pull request.
We would need a solution which addressed both, older and new problem.