search

vmware / vsphere-automation-sdk-python

Python samples, language bindings, and API reference documentation for vSphere, VMC, and NSX-T using the VMware REST API
MIT License
748 stars 312 forks source link

Add "py_modules" to setup.py, to fix incompatibility with Setuptools in Version 61 and 62 #304

Closed KeyboardInterrupt closed 1 year ago

KeyboardInterrupt commented 2 years ago

This fixes an incompatibility with Setuptools in Version 61 and 62, see the Issue: https://github.com/vmware/vsphere-automation-sdk-python/issues/303

For more Information on the py_modules option, check out: https://docs.python.org/3/distutils/setupscript.html#listing-individual-modules

Thank you all for the great work on the vsphere python sdk!

vmwclabot commented 2 years ago

@KeyboardInterrupt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 2 years ago

@KeyboardInterrupt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 2 years ago

@KeyboardInterrupt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 2 years ago

@KeyboardInterrupt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

KeyboardInterrupt commented 2 years ago

I am sorry, But it appears I am unable to please the @vmwclabot, I used git commit -s as described in the linked Document, and the Information is matching up with my GitHub configuration, anyone, any Idea, what I might be doing wrong ^^?

bradhvr commented 2 years ago

Can someone on the vmware team please help out here? The pip SDK install has been broken for almost a month.

vanditsmehta commented 2 years ago

Can someone on the vmware team please help out here? The pip SDK install has been broken for almost a month.

Hi @bradhvr , Can you please check again, the issue has already been fixed in the latest commits.

bradhvr commented 2 years ago

Hi @vmehtavmware thank you, are there plans to put out a new release with these changes? We lock our requirements.txt to a specific tag to ensure stability.

vanditsmehta commented 2 years ago

Hi @vmehtavmware thank you, are there plans to put out a new release with these changes? We lock our requirements.txt to a specific tag to ensure stability.

Hi @bradhvr , Yes, we will put out a new release for these changes after adding few new samples. We will create the release with new tag mostly today or max by tomorrow.

sodul commented 1 year ago

@vanditsmehta would it be possible for you to create a bug fix release of 7.x with these fixes? We have customers that are still running VSphere 6.x so we cannot upgrade to 8.x, yet we would like to not be blocked by this bug.

mtsvetanov commented 1 year ago

@sodul you can still take the latest release of the SDK, it is compatible with vSphere 8.0, 7.x, 6.x. Of course, some of the APIs that are available in the latest SDK version will not be present on earlier versions of vSphere and you have to be mindful about it.

sodul commented 1 year ago

@mtsvetanov The SDK release notes state "Removed support for older versions of vCenter Server 6.5/6.7" if the latest version is actually compatible the notes are misleading.

mtsvetanov commented 1 year ago

vCenter Server 6.5/6.7 already reached End of General support last year, and are reaching End of Support Life later this year. https://lifecycle.vmware.com/#/ https://www.vmware.com/support/lifecycle-policies.html

I agree that messaging on the SDK side is a bit aggressive. Technically there isn't anything that prevents using 8.0 SDK with vCenter 6.7 or 6.5.