vmware / weathervane

Virtual-Infrastructure and Cloud Performance Benchmark
Other
153 stars 39 forks source link

change readerwriter lock to simple sync object lock #252

Closed bhoflich closed 1 year ago

bhoflich commented 1 year ago

It does not appear the current implementation in PerWorkloadStatsColletor using a reader writer lock is correct.

This results in log error messages like this: 0/0/logs/workloadDriver/driverCluster/wklddriver-3.log:xxxxx [http-nio-80-exec-6] WARN c.v.w.w.c.s.s.PerWorkloadStatsCollector - statsIntervalComplete: caught null operationStats.

Updated to use simple locking with a synchronized block on an object.

Also updated the version.txt to match the branch 2.1.2-dev

vmwclabot commented 1 year ago

@bhoflich, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 1 year ago

@bhoflich, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.