search

vn7n24fzkq / github-profile-summary-cards

A tool to generate your github summary card for profile README
https://github-profile-summary-cards.vercel.app/demo
MIT License
2.6k stars 313 forks source link

fix: adjust svg size to match the viewBox #134

Closed ithelor closed 1 year ago

ithelor commented 1 year ago

Hey.

So while messing with my profile repo I noticed that your card isn't quite aligned. After having inspected the SVG I found out that the actual content isn't taking all the space it should (?).

Though I don't really get the reason behind setting the attributes to 98%.

image

image

vn7n24fzkq commented 1 year ago

Yeah, I remember. in the early version we got some viewbox match problems from different font families, it seems I forgot to modify it after we fixed that.

Thank for you noticing that.

vn7n24fzkq commented 1 year ago

I am noticed that not a bug, we set the width 98% to display the borderline, so I am going to fix this again. But thank you again.