search

vn7n24fzkq / github-profile-summary-cards

A tool to generate your github summary card for profile README
https://github-profile-summary-cards.vercel.app/demo
MIT License
2.6k stars 313 forks source link

Improve wording in summary cards #16

Closed Matteas-Eden closed 3 years ago

Matteas-Eden commented 3 years ago

See title.

I felt that some of the wording used in the cards was awkward, or that some added capitalisation in places could improve the way the cards look. Originally I was going to simply maintain a fork, but integrating that fork with GitHub actions became troublesome, so instead I'm (attempting to) contribute to the main repo.

I wasn't sure whether to open an issue or not. Let me know if there's a preference for PRs to have issues attached.

UPDATE Closes #17

vn7n24fzkq commented 3 years ago

@Matteas-Eden Thanks for your contribution. It would be good to have an issue , because this change will effect many users, an issue can get more people to participate in the discussion.

I'm not a native English speaker, so the grammar or used word in the cards might be odd, any PR about that I will be appreciated.

vn7n24fzkq commented 3 years ago

By the way, I would like to merge this PR if no one else disapproved it.

Matteas-Eden commented 3 years ago

@vn7n24fzkq I've created an issue for what this PR solves in an attempt to increase visibility and encourage discussion. The issue is #17.

vn7n24fzkq commented 3 years ago

Thanks!