search

vn7n24fzkq / github-profile-summary-cards

A tool to generate your github summary card for profile README
https://github-profile-summary-cards.vercel.app/demo
MIT License
2.6k stars 313 forks source link

feat: Added exclude argument for languages #97

Closed MiranDaniel closed 1 year ago

MiranDaniel commented 2 years ago

Added an optional exclude argument for excluding languages from the cards. Accepts comma separated lists (ex. cpp,java).

vn7n24fzkq commented 2 years ago

Awesome work! I will review this tomorrow.

vn7n24fzkq commented 2 years ago

Do we need those modules in package.json? 

"serverless": "^3.20.0",
"vercel-node-server": "^2.2.1"

And if possible, I think we should change the package-lock.json just before release. Everything else looks good to me.

MiranDaniel commented 2 years ago

My bad, didn't notice those 2 new modules, not needed.

vn7n24fzkq commented 2 years ago

Thanks! Also, package-lock.json should not be changed, can you revert that?

vn7n24fzkq commented 2 years ago

And there are some conflicts in README.md. If it's not trouble for you could you please resolve that?

MiranDaniel commented 2 years ago

Fixed!

vn7n24fzkq commented 2 years ago

Thanks! @MiranDaniel Seems package.json got a parsing error, so Tests and Lint cannot pass. I guess because there is an extra comma at the end of "retry-axios": "^2.6.0", We need to remove it. After that, we can merge this PR.

vn7n24fzkq commented 2 years ago

Oh, we have some more discussion in #94, need your reply.

vn7n24fzkq commented 2 years ago

@MiranDaniel , Hi, do you still working on this? If you are busy, I can help with the rest steps. I think we can merge this after solving the conflict.

vn7n24fzkq commented 1 year ago

Hi @MiranDaniel.

Are you still working on this? Since this PR is almost done, if you don't mind I can take over the rest part and keep your commit in the commit history.