vn971 / rua

Build tool for Arch Linux providing control, review and jailed build options
GNU General Public License v3.0
424 stars 42 forks source link

Review prompt is very verbose #125

Open qoh opened 4 years ago

qoh commented 4 years ago

It takes a some scanning to actually parse the prompt of available options as you're reviewing a package for merge or build, due to how long and wordy it can get:

[D]=view upstream changes since your last review, [M]=accept/merge upstream changes, [S]=(shellcheck not available until you merge), [T]=run shell to edit/inspect, [O]=(cannot use the package until you merge)

Some comments, all opinionated - I would prefer these changes, but it could also be behind an option:

All in all that prompt could, for example, be:

[D]=view upstream changes [T]=review in shell [M]=accept changes

For the next step:

[S]=run shellcheck on PKGBUILD, [D]=(identical to upstream, empty diff), [T]=run shell to edit/inspect, [O]=ok, use package.

That could be as simple as:

[S]=run shellcheck on PKGBUILD [T]=review in shell [O]=continue

It might also be worth it to have a ? action that explains the current state further, what rua is expecting the user to do, and what each action is for.

thezealousfool commented 4 years ago

As an extension to the above proposal, I would also like to propose to add default action at each step, similar to say apt-get install's accept change [Y/n], Y is the default action (if you do not type anything and press enter that option is chosen).

For eg., accept changes as the default action for the first step and ok as the default for the next step like

[d]=view upstream changes [t]=review in shell [M]=accept changes
[s]=run shellcheck on PKGBUILD [t]=review in shell [O]=continue