Open qoh opened 4 years ago
As an extension to the above proposal, I would also like to propose to add default action at each step, similar to say apt-get install
's accept change [Y/n]
, Y
is the default action (if you do not type anything and press enter that option is chosen).
For eg., accept changes
as the default action for the first step and ok
as the default for the next step like
[d]=view upstream changes [t]=review in shell [M]=accept changes
[s]=run shellcheck on PKGBUILD [t]=review in shell [O]=continue
It takes a some scanning to actually parse the prompt of available options as you're reviewing a package for merge or build, due to how long and wordy it can get:
Some comments, all opinionated - I would prefer these changes, but it could also be behind an option:
since your last review
probably isn't necessary, it could just beview upstream changes
;accept/merge upstream changes
likeaccept
, and shorten toaccept changes
;[S]=(shellcheck not available until you merge)
;run shell to edit/inspect
could bereview in shell
;[O]=(cannot use the package until you merge)
--this one specifically makes some sense to list since it could otherwise be confusing (but it still is for some), but that could be resolved in other ways, such as: moving the merge action first/last and appendingand continue
.All in all that prompt could, for example, be:
For the next step:
(identical to upstream, empty diff)
is a bit of an odd action to list, surely this could be omitted, or worded better and more succintly;ok, use package.
could just becontinue
.That could be as simple as:
It might also be worth it to have a
?
action that explains the current state further, whatrua
is expecting the user to do, and what each action is for.