Add colors to review menu

vn971 / rua

Build tool for Arch Linux providing control, review and jailed build options

GNU General Public License v3.0

424 stars 42 forks source link

Add colors to review menu #161

Closed intgr closed 3 years ago

intgr commented 3 years ago

With colors it's much easier to tell, where one menu option ends and the next one begins.

The color scheme is based on a simple "traffic lights" concept:

green is safe (shellcheck/diff)
red may be dangerous (use package)
yellow is in between (merge)

Additionally:

"run terminal" is cyan, to distinguish it from other options
inactive options appear gray.

In my testing it works well with both white and black terminal background.

intgr commented 3 years ago

Screenshots of the result:

vn971 commented 3 years ago

Interesting, thanks! I wonder how it plays out with the SUID warning, let me briefly test that out before merging

vn971 commented 3 years ago

OK, this PR doesn't actually change "tar_review" stage, only package review at build stage. I think it's good, thanks again for the detailed commit message & the screenshots, plus a nice small PR! :raised_hands: