Add colors to tar check menu

[intgr]

Using the same color scheme as review menu in commit a800fb259670ea947dc391ba54bf650e04b6261a (PR #161)

[intgr]

I didn't realize that the tar check menu already has colors. I see how adding color to other options might reduce visibility of the previously red options.

Making them yellow seems to make them stand out more:

[Morganamilo]

Just mentioning yellow can look quite bad on a light terminal.

[vn971]

Looking at the screenshots, I think I'm definitely aligning more to the "traffic lights" rule you mentioned before. In this case it'd be one potentially dangerous operation [O]=ok, proceed and highlighting the potentially dangerous parts of SUID, maybe install file as well. Technically all files should be reviewed, because a file placed in cron directory is just as "dangerous" as an install file

[intgr]

This is what darker yellow would look like (better for white background)

[vn971]

I was thinking of something like that: AFK now, will be back a bit later today

Maybe showing install file / SUID files could be yellow (or a less intense red) color as well, I like some parts of your screenshot above. *I'll back later

[vn971]

I played some more with the idea, and no matter what I do, this kinda doesn't make sense for me. The only really dangerous action is to install the package, but the parts the user should be paying attention to are not those. I'm thinking of the following design

Any thoughts on the "dangerous action" / "potentially dangerous details" concept mismatch?

[intgr]

My initial reason for creating these pull requests was that I found it hard to tell, where one option ends and the next one starts. So I'd prefer to have something that more clearly separates the options. Color and bolding the keyboard shortcut made them quite distinct. But without color, the effect is less pronounced:

I agree that the colors (like in https://github.com/vn971/rua/pull/163#issuecomment-855197794) do seem excessive. On the other hand, it slightly bothers me that the colors in the menus work differently now (compared to #161). But I can live with that. :)

[vn971]

I've finally got back to the MR :sweat_smile: (sorry, it's been a really long time, I acknowledge). I'm trying the PR out at the moment, I have a few questions

[vn971]

Merged!

Before: After:

[intgr]

Thanks! :) I'm fine with this, it makes the available choices clearer without excessive color.

"hey, you have both SUID and an installation file at your hands, be sure to review it!"

Yeah, I think I commented the if out just to test the output. Didn't intend to leave it like that.