include paths that start with /globalassets when matching

vnbaaij / Baaijte.Optimizely.ImageSharp.Web

Use SixLabors.ImageSharp.Web in Optimizely

Apache License 2.0

17 stars 15 forks source link

include paths that start with /globalassets when matching #1

Closed nkuebler001 closed 3 years ago

vnbaaij commented 3 years ago

Thanks for this fix. It has been implemented in package version 1.0.1

nkuebler001 commented 3 years ago

@vnbaaij Thanks for merging my fix. I installed the latest nuget package (1.0.2) and tested and still images that were in globalassets were not being resized so I downloaded both nuget packages from the releases page and extracted them locally and opened the assemblies in dotpeek . It appears that my changes while they have been merged into the main branch have not made it into the nuget packages. See the screenshot below from 1.0.1 in dotpeek:

vnbaaij commented 3 years ago

I made a mistake in 1.0.1 so republished as 1.0.2. Apparently something went wrong...will republish again.

vnbaaij commented 3 years ago

Can you try with the nupkg added to the release here on GitHub?

nkuebler001 commented 3 years ago

I just check the 1.0.2 package on the releases page and am not seeing the change in the package.

Is this the correct one? https://github.com/vnbaaij/Baaijte.Optimizely.ImageSharp.Web/releases/download/V1.0.2/Baaijte.Optimizely.ImageSharp.Web.1.0.2.nupkg

vnbaaij commented 3 years ago

Should be the correct one yes. I'll create a 1.0.3 version right now.

vnbaaij commented 3 years ago

Can you please try with the v1.0.3 release

nkuebler001 commented 3 years ago

Same result ... perhaps there's someissue with the process that creates the nuget package?

vnbaaij commented 3 years ago

Ok, think I've found it. Was indeed in the package creation. Can you try with the 1.0.3 package from the release again?

nkuebler001 commented 3 years ago

Looks good 👍

vnbaaij commented 3 years ago

Great, republishing it to the Optimizely feed now.