Closed trossi closed 6 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
2b927cb
) 91.04% compared to head (122f847
) 90.08%. Report is 1 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
rdata/parser/_parser.py | 75.00% | 5 Missing :warning: |
rdata/parser/_ascii.py | 94.44% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@vnmabus I rebased the branch to fix conflicts and fixed some mypy issues found locally. The mypy CI action seems not be working, see a log here.
Line ending of _parser.py
had changed in develop branch, so I rebased this PR again (it seemed clearer approach than resolving merge conflict with the two files with different line endings). Style issues by ruff are fixed also.
@vnmabus Thanks for reviewing and merging!
This PR adds parser for ascii files.
See also #31.
A minimal test is also added for reading the following files generated in R:
These files are generated both on Linux and Windows. Windows-R seems to use \r\n line ending for rds files but \n for rda files (tested on R 4.3.2).
@vnmabus Could you review? Do you think that this kind of testing would be sufficient?