search

vnmakarov / mum-hash

Hashing functions and PRNGs based on them
146 stars 12 forks source link

Compilation warnings with gcc #15

Closed a16bitsysop closed 3 years ago

a16bitsysop commented 3 years ago

When compiling with the -wno-unused-value flag the following warning is produced:

mum.h:118:13: warning: right-hand operand of comma expression has no effect [-Wunused-value]
  118 |   lo = v * p, hi;
      |
vnmakarov commented 3 years ago

Thank you very much for reporting this. It seems a typo which makes mum hash wrong for aarch64. I guess initially it was a declaration, not a statement.

I fixed it https://github.com/vnmakarov/mum-hash/commit/322fdd931c6e61c463e04ce5f37cab4918c4d2d6#diff-58cc585617c05bdc7075c67e5fc222c3af5db6d8bdef9b8a2f2a81176e40eeb6.

a16bitsysop commented 3 years ago

Thanks, that fixes it.