search

vnmakarov / yaep

Yet Another Earley Parser
Other
137 stars 14 forks source link

Switch to MIT license #20

Closed TheCount closed 5 years ago

TheCount commented 5 years ago

This PR depends on PR #19.

It has only one additional commit, switching out the GPL boilerplate with the MIT license boilerplate, adding it where it is missing.

It also changes the date range from 1997-2015 to 1997-2018.

This implements https://github.com/vnmakarov/yaep/issues/18#issuecomment-429119001.

vnmakarov commented 5 years ago

Thank you for trying to improve YAEP and removing the old code (it is dated when people used RCS :).

My biggest concern with your changes is that you are trying to switch YAEP from autoconf to cmake.

They both have advantages and disadvantages. I really would like to save autoconf. First I tried to apply changes without cmake but I found it is too big work. Now I am thinking to save autoconf and cmake so it could be built by any of these tools.

So I am going to work on this. Your pull request is not forgotten but the changes will be applied in a week or two.

TheCount commented 5 years ago

Yes, I've seen projects using both CMake and autotools (as in configure.ac and Makefile.am), leaving the choice of which one to use to the user.

This works well, but I'd advise to start from scratch with the autotools. Those .tst.in files were a nightmare to maintain (unless they are autogenerated), and the cocom-config.h didn't do anything (it had some useful tests for ANSI-C features, but these days, ANSI-C is a given; no need to test for it).