search

vnoelifant / movie-search-app

0 stars 0 forks source link

Movie detail updates #73

Closed vnoelifant closed 10 months ago

vnoelifant commented 1 year ago

Refactor of the search function in views. Updates to the movie detail view and model fields. In TMDB, the videos and recommendations are different endpoints than the movie details (see https://developer.themoviedb.org/reference/intro/getting-started), but in the code, I just gave them a many to many relationship with the Movie (details) model. So you'll see that in the views.py file, in the movie_detail function, I am only passing in the movie_detail as a context, which includes videos and recommendations. I am not sure if that is the most efficient approach, but I am able to view the data this way. Let's discuss and review my updates at the next code review. This relates to issue #70.

vnoelifant commented 10 months ago

Added model improvements, fixed issue #70, and GPT function refactoring. Eventually, per our Circle convo, I want to move to class refactoring. It looks like the videos side scroll section needs some adjustments because each video seems too close together. This is an example for the Mission Impossible movie from home page. @bbelderbos . image

bbelderbos commented 10 months ago

It looks like the videos side scroll section needs some adjustments because each video seems too close together. This is an example for the Mission Impossible movie from home page.

ok good progress, maybe you can start with these css stylings? let me know if that helps / if you need more help ...

image