search

vnoelifant / movie-search-app

0 stars 0 forks source link

Class refactor #77

Closed vnoelifant closed 7 months ago

vnoelifant commented 9 months ago

Updated per https://github.com/vnoelifant/movie-search-app/issues/75#issuecomment-1807380516. Have to double check that I have all the right model fields based on the tv.html template, and modify the watchlist functions to account for movies. Might want to check what else needs to be cached based on views.py. Mostly the class updates were in media.py, but if you have suggestions on how to make views.py more maintainable and readable let me know!

vnoelifant commented 7 months ago

Great work, but please do smaller scoped pull requests from here on. Can you please look at the issues and highlight what features you'll focus on the coming months, open new ones if needed. Deployment is an important one we need to get done, have you decided on a platform yet?

Thanks @bbelderbos. Understood. I had not created a new one because it wasn't clear to me in prior discussions whether I should create new PRs for completely new features or if the existing PR is getting lengthy. I wasn't sure how to categorize a new PR since I was doing general class refactoring for this PR. So I have to know how to better categorize new PRs. I would like to use Heroku. But before that, is it advised I finish the issues on TODO and In progress in my project board? Those are the ones I really want to focus on.

vnoelifant commented 7 months ago

Great work, but please do smaller scoped pull requests from here on. Can you please look at the issues and highlight what features you'll focus on the coming months, open new ones if needed. Deployment is an important one we need to get done, have you decided on a platform yet?

Thanks @bbelderbos. Understood. I had not created a new one because it wasn't clear to me in prior discussions whether I should create new PRs for completely new features or if the existing PR is getting lengthy. I wasn't sure how to categorize a new PR since I was doing general class refactoring for this PR. So I have to know how to better categorize new PRs. I was just a little confused on the process, and think would be helpful if there was a list of criteria for when to create a new PR. I would like to use Heroku. But before that, is it advised I finish the issues on TODO and In progress in my project board? Those are the ones I really want to focus on.

bbelderbos commented 7 months ago

Great work, but please do smaller scoped pull requests from here on. Can you please look at the issues and highlight what features you'll focus on the coming months, open new ones if needed. Deployment is an important one we need to get done, have you decided on a platform yet?

Thanks @bbelderbos. Understood. I had not created a new one because it wasn't clear to me in prior discussions whether I should create new PRs for completely new features or if the existing PR is getting lengthy. I wasn't sure how to categorize a new PR since I was doing general class refactoring for this PR. So I have to know how to better categorize new PRs. I would like to use Heroku. But before that, is it advised I finish the issues on TODO and In progress in my project board? Those are the ones I really want to focus on.

Yes let's go Heroku, AWS is a bit more complex and it has been less transparent to me what was running in the background leading to hidden charges. Heroku is not free anymore, but the deployment is way easier.

For the PRs, let's look at this as we go. Heroku should be one branch and PR, next features we should break down into smaller chunks leading to smaller PRs ...