Open actionless opened 5 years ago
It only happens in self-compiled version, right? Does AppImage have this regression?
i can't say because while qt5ct not works for me in AppImage — it's always default Fusion theme, not dark one
yes, the problem appears in both AppImage and native build
It seems that qt5ct will override the qss of vnote. Just use a blank qss if you are using qt5ct. There is no better way for this.
with blank qss there is one small problem -- icons are not themed, so it should be smth like:
.panel .icon {
color: @foreground;
}
but idk how exactly it should look in qss
and other, even smaller, problem, mode indicator in the bottom right
You need to tune the qss instead of deleting all the stuff.
but can it be done in scope of v_native theme? otherwise it's not clear the purpose of such theme if it meant to be native but it's not fully is
Yes. But I lack such an env to tune it. Could you help to clean up the v_native
theme? It is easy to guess the meaning of the qss elements. I think you need to only delete part of it.
Thanks!
this solved the biggest problems:
@@ -543,8 +543,7 @@
QWidget
{
- color: @widget_fg;
- font-family: "Hiragino Sans GB", "冬青黑体", "Microsoft YaHei", "微软雅黑", "Microsoft YaHei UI", "WenQuanYi Micro Hei", "文泉驿雅黑", "Dengxian", "等线体", "STXihei", "华文细黑", "Liberation Sans", "Droid Sans", "NSimSun", "新宋体", "SimSun", "宋体", "Helvetica", "sans-serif", "Tahoma", "Arial", "Verdana", "Geneva", "Georgia", "Times New Roman";
}
but idk how to solve the remaining
here's custom qt5ct style i am using, ~/.config/qt5ct/colors/oomox-monovedek_lcars.conf
:
[ColorScheme]
active_colors=#888a85, #0e0021, #0e0021, #0e0021, #0e0021, #0e0021, #b9bcb5, #b9bcb5, #888a85, #221428, #0e0021, #0e0021, #dc5e86, #000000, #dc5e86, #888a85, #0e0021, #888a85, 0e0021, #888a85
disabled_colors=#69676c, #0e0021, #0e0021, #0e0021, #0e0021, #0e0021, #939291, #939291, #69676c, #221428, #0e0021, #0e0021, #dc5e86, #000000, #dc5e86, #69676c, #0e0021, #69676c, #0e0021, #69676c
inactive_colors=#888a85, #0e0021, #0e0021, #0e0021, #0e0021, #0e0021, #b9bcb5, #b9bcb5, #888a85, #221428, #0e0021, #0e0021, #dc5e86, #000000, #dc5e86, #888a85, #0e0021, #888a85, #0e0021, #888a85
spotted the regression with
v_native
theme, not only foreground color not distinguishable but also system font got overridden:here's with blank qss as was discussed in this ticket https://github.com/tamlok/vnote/issues/148:
Originally posted by @actionless in https://github.com/tamlok/vnote/issues/258#issuecomment-470125554