refactor(demo/clock): avoid duplicate graduations

vobyjs / voby

A high-performance framework with fine-grained observable-based reactivity for building rich applications.

https://voby.dev

MIT License

879 stars 22 forks source link

refactor(demo/clock): avoid duplicate graduations #14

Closed high1 closed 2 years ago

high1 commented 2 years ago

in mapRange function callback, all numbers divisible by 5 are hours, so use that information to draw all graduations in one loop

fabiospampinato commented 2 years ago

Yeah this make sense, I've thought about it, but I prefer the cleaner code, rendering those invisible marks in theory might be useful under other scenarios for animations purposes or something, here they are just completely useless, but I don't think this optimization makes a different in practice, I prefer the cleaner code. Thanks anyway.