search

voc / plugin.video.media-ccc-de

Kodi plugin for https://media.ccc.de/
Other
43 stars 4 forks source link

re-live support for unreleased videos in conferences #34

Closed master-lincoln closed 3 years ago

master-lincoln commented 3 years ago

Implements a basic version of #24

I didn't find a description of the ReLive API so I just implemented it naively by looking at some of the jsons.

This implementation adds a ReLive (unreleased) folder at the bottom of a conference folder in case there are unreleased recordings. (this has the downside that at least one recording needs to be released for the conference folder to show up to be able to access the ReLive menu afaik)

probonopd commented 3 years ago

Tested, works for me :+1: Thank you very much. Highly appreciated.

probonopd commented 3 years ago

Watched a couple of rc3 re-lives yesterday night on my Big Screen. Definitely a very worthwhile addition.

master-lincoln commented 3 years ago

I pushed the proposed changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #34 (dc5dd0e) into main (f6c6816) will increase coverage by 0.70%. The diff coverage is 59.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   55.14%   55.85%   +0.70%     
==========================================
  Files          12       14       +2     
  Lines         457      564     +107     
  Branches       52       58       +6     
==========================================
+ Hits          252      315      +63     
- Misses        200      244      +44     
  Partials        5        5
Impacted Files Coverage Δ
addon.py 0.00% <0.00%> (ø)
resources/lib/http.py 0.00% <0.00%> (ø)
resources/lib/relive.py 100.00% <100.00%> (ø)
resources/lib/test_relive.py 100.00% <100.00%> (ø)
resources/lib/stream.py 93.33% <0.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6c6816...dc5dd0e. Read the comment docs.

TobiX commented 3 years ago

Thank you very much for the contribution!