search

voc / schedule

http://c3voc.de/wiki/schedule
14 stars 18 forks source link

Add field 'feedback url' #39

Closed saerdnaer closed 11 months ago

saerdnaer commented 5 years ago

-> New field on Event in schedue.xml and schedule.json with absolute URL to the corresponding form as specified in https://git.cccv.de/hub/hub/-/issues/430#note_20618

johnjohndoe commented 4 years ago

I like to continue the discussion on how to integrate a feedback_url in the aggregated schedule XML containing data from various backend (frab, Pretalx, wiki, ...). Here I try to propose a "specification" - please be welcome to correct me, to complement or to comment.

Current potential consensus

Aggregated schedule

/cc @manno @rixx @toto

rixx commented 4 years ago

I'm not sure that adding a mandatory field to the already-tentative "standard" of schedule.xml is a good idea, because it would mean that a number of older/different tools won't pass validation.

Other than that: pretalx will accept PRs implementing whatever the final consensus turns out to be, I don't care which particular proposal wins out.

saerdnaer commented 4 years ago

@rixx Of course this would be an optional field, so old exports would still be valid.

saerdnaer commented 4 years ago

@johnjohndoe For aggregated schedules I am currently thinking about a redirect service e.g. https://data.c3voc.de/feedback/36C3/6a32cb72-a69d-423c-91b5-60d88eb8e6c7 or https://data.c3voc.de/feedback/6a32cb72-a69d-423c-91b5-60d88eb8e6c7 which then would redirect to the corresponding form. In this case this would be announced via "feedback_url": "https://data.c3voc.de/feedback/{guid}", or <feedback_url>https://data.c3voc.de/feedback/{guid}</feedback_url> in the everything schedule header.

johnjohndoe commented 4 years ago

@saerdnaer At this point a redirect service looks fine to me. I guess Android should be able to handle this.

:thinking: In the future I might want to implement a native feedback form which allows users to stay in the app when submitting a feedback. This would require in app knowledge about the kind of feedback form. I here assume that the feedback forms of frab and Pretalx differ by their fields. This native feedback form could be implemented as an API request if an endpoint is available.

toto commented 4 years ago

@johnjohndoe Indeed having user feedback native in app would be great.

I see three options to make this happen:

  1. A unified endpoint that could talk to both systems somewhere (since the iOS apps use a middleware anyways it could be used for this but it would not be standalone)
  2. We could try to get pretax and frab to unify the fields
  3. We could specify the fields and values in some way in the format.

I think the 3rd option is probably to complex for it's own good and it requires a lot of code on all platforms

rixx commented 4 years ago

I'm afraid pretalx won't be able to commit to complete compatibility with frab feedback forms. Providing compatibile exports is something I'll gladly provide, but limiting pretalx functionality would be going too far, especially as the feedback form will probably evolve over time.

johnjohndoe commented 4 years ago

To keep the scope small and reachable I like to limit myself to the conversation about the feedback_url. I agree with what was written - especially with the new field being optional. Is there anything stopping us at this point to continue with this iteration step?

@toto We can discuss a potential native feedback form somewhere else if you like.

toto commented 4 years ago

Sounds good to me 👍

johnjohndoe commented 11 months ago

:link: Frab/Pretalx-Feedback URL in aggregiertem schedule.xml/json

johnjohndoe commented 11 months ago

@rixx & @toto Would you please join the discussion in the new issue linked above :arrow_up: to bring the topic forward?