voc / streaming-website

Home of streaming.media.ccc.de
50 stars 109 forks source link

Schedule view is not timezone-aware #239

Open Kunsi opened 6 months ago

Kunsi commented 6 months ago

Screenshot 2024-05-31 at 15-20-28 Live-Streams – Electromagnetic Field 2024 Streaming

This conference is in UTC+01:00 (Europe/London), but the streaming website does always show dates in Europe/Berlin (UTC+02:00 currently). This leads to confusion by visitors, because the site states "talk running since (time in 30 minutes)".

The shown talk title is correct however, so this is just a display issue, the detection of the running talk is not affected.

I presume this also happens on the schedule view under the video player, which is correct by accident if the browser timezone matches the conference timezone. The schedule view should always show the conference timezone, no matter which timezone the browser is in.

saerdnaer commented 5 months ago

previous installments of this event series used following hack:

https://github.com/voc/streaming-website/blob/master/configs/archive/emf2018/config.php#L3-L4 https://github.com/voc/streaming-website/blob/9995dd4dc893b02244869b6b13ab4ba3969c28fc/configs/archive/emf2018/config.php#L3-L4

Should we extend the conferenceJSON class to do something similar based on the time_zone_name config option?

https://github.com/voc/streaming-website/blob/9995dd4dc893b02244869b6b13ab4ba3969c28fc/docs/config-schema.json#L83-L89

Kunsi commented 5 months ago

Yeah, that would be ideal.

iSchluff commented 5 months ago

Should we extend the conferenceJSON class to do something similar based on the time_zone_name config option?

https://github.com/voc/streaming-website/blob/9995dd4dc893b02244869b6b13ab4ba3969c28fc/docs/config-schema.json#L83-L89

Probably a good idea, although I would recommend sticking with camelCase like in other properties.

I presume this also happens on the schedule view under the video player, which is correct by accident if the browser timezone matches the conference timezone. The schedule view should always show the conference timezone, no matter which timezone the browser is in.

I have previously added some code to the schedule to correctly show the current time in the timezone of the event

https://github.com/voc/streaming-website/blob/9c71454046459c594811a31da4875c8fae8c8335/model/Schedule.php#L315

https://github.com/voc/streaming-website/blob/9c71454046459c594811a31da4875c8fae8c8335/assets/js/lustiges-script.js#L237-L242

Although I am open to suggestions on how to better show this. I would have liked to display the name of the event timezone, but that wasn't possible previously because the name is not in the schedule. With the config suggested by @saerdnaer this would be possible