voc / voctomix

Full-HD Software Live-Video-Mixer in python
https://c3voc.de/
MIT License
575 stars 104 forks source link

Default-Setting for Streamblanker #188

Closed MaZderMind closed 6 years ago

MaZderMind commented 6 years ago

In some Situations it might be beneficial, to default to a blanked stream on startup. For example a Restart in the morning would not un-blank all streams.

derpeter commented 6 years ago

i think this is a good idea. It maybe necessary to add a checkbox or something similar to the GUI to make this setting visible / changeable. I'm not sure if voctocore can persist such setting done over the chat in its config file to survive restarts therefore this may result in another feature request.

Florob commented 6 years ago

I'm not sure why one would want to disable this in the GUI. Restarts are AFAIK already a fairly manual process, and I am not aware of a case where it would be critical for the stream to be live immediately.

That said, a separate feature, that would make sense to me in this context, is persisting the current state (not just streamblanker, but also selected layout and inputs) across restarts. This should be in a separate file, with defaults being read from the config if the file doesn't exist.

derpeter commented 6 years ago

@Florob the example @MaZderMind gave is probably the most common one. On the other hand besides intentional restarts there can always be crashed either of vocotomix or the whole system as well as power outages. In all this cases you want the system come back as soon as possible in the desired state. This state depends on if a talk is running or not.

Florob commented 6 years ago

@derpeter From that description it seems to me like the checkbox you suggest would always precisely reflect the state of the existing streamblanker toggle. Which lines up with my suggestion of persisting the current state. Or am I missing something here?

CarlFK commented 6 years ago

for the case of "it crashed, restart quick": I can understand and even want that, but... I'm not sure I want more code that works around things crashing.

It is a trade off.

One of the things that makes vocto stable is small feature set and code base.

On Fri, Feb 16, 2018 at 11:19 AM, Florob notifications@github.com wrote:

@derpeter https://github.com/derpeter From that description it seems to me like the checkbox you suggest would always precisely reflect the state of the existing streamblanker toggle. Which lines up with my suggestion of persisting the current state. Or am I missing something here?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/voc/voctomix/issues/188#issuecomment-366300038, or mute the thread https://github.com/notifications/unsubscribe-auth/AABauTmp0q9ra-KV3v-AUWgmI2B9_ihHks5tVbingaJpZM4SGd6o .

-- Carl K

derpeter commented 6 years ago

@Florob it would only reflect that if the state is the desired restart behavior. @CarlFK well python config lib wrapps such sings very nicely i would not expect more than a view lines of code in vocotocore to implement this. And the lib below is very stable und widely used.