voctolight: Refactor into a plugin architecture

micolous commented 5 years ago

Previous Raspberry Pi support becomes rpi_gpio plugin
New plugin: stdout (which prints the tally light status to stdout)
Add test program for running without voctomix

This allows multiple types of tally light, not just Raspberry Pi... (see #236)

micolous commented 3 years ago

I notice that this code has since branched into voctomix2. I am unable to test it with this branch, so porting it forward is left as an exercise for the maintainers.

derpeter commented 3 years ago

LGTM. @micolous thanks for the contribution. The vocotomix2 branch reflects fundamental changes in vocotomix and will end up in a very different application. The normal vocotomix branch is out of development for at least a year and we should make this more clear. At least from our side there will be no further development on the old code/pipline.

Regarding tally: i like the plugin idea very much. We currently plan to move the logic out of voctolight and into the core. So voctolight will not need to be changed everytime we change logic or messages in the core. The basic idea it that the core is emitting a message like "tally 1 on" rather that the tally is guessing its state from listening to the chat of the core. We might also implement e.g. mqtt to make it even simpler to build tallys and other accessories. This has no happened yet and if you have thoughts on this let us know.

voc / voctomix

voctolight: Refactor into a plugin architecture #235