voc / voctoweb

voctoweb – the frontend and backend software behind media.ccc.de
GNU General Public License v3.0
188 stars 56 forks source link

Make frab event IDs searchable via slug #46

Closed timpritlove closed 8 years ago

timpritlove commented 8 years ago

The event ID is the only unique item about an event. However currently the event IDs are not included on the event pages and are not searchable via the search box.

Feature requests:

manno commented 8 years ago

Actually there is a longer database independent guid to identify talks. This seems highly frab specific and is not useful for other videos.

timpritlove commented 8 years ago

You mean it should not be possible to search for event IDs?

manno commented 8 years ago

We should use the events title or slug.

Frabs internal database IDs are not stable, i.e. they might change if we re-create the database. This actually happened several times. In the past we maintained lists of mappings, new id -> old id. That was a huge problem for all our scripts.

Frab still exposes the event id in the URL of an events detail page, but generally the event id is not exposed to other systems (via public schedule).

Furthermore media.ccc.de is meant as a frontend to lots of different video files, not just conferences using frab.

media.ccc.de actually doesn't know the ID... well, this isn't entirely true. Since the ID is exposed in the URL and media.ccc.de knows the link to the fahrplan page, we could search the event.link value to realize the search? (ping @florolf @MaZderMind)

timpritlove commented 8 years ago

All I ask for is being able to search for an important event property and having it displayed. it exists and it is meaningful to the event. it does not need to be unique to Frab internally.

However: the initial idea behind the event ID within Pentabard was it to be unique. Adding the event slug it can still be made it into something unique: "32C3:7304" could be as unique as necessary.

saerdnaer commented 8 years ago

Just for reference: We are talking about adding the line 'event.link', at https://github.com/voc/media-search-prototype/blob/master/server/search.pl#L49 ?

florolf commented 8 years ago

I don't think extracting information from event.link is in any way a good idea. Parsing the slug seems dubious, too. The format of those things is too volatile to be relied upon (or rather: Nobody will think about the poor script parsing those values when deciding to change the format). Those values are not an API. If we want to search for a field, it should be cleanly exposed by media.

manno commented 8 years ago

@florolf Not extracting, just searching the URLs for sub strings, like we do with the description?

saerdnaer commented 8 years ago

@florolf What speaks agains adding the slug to the search index? Shouldn't the user get a matching result when she enters the full slug?

timpritlove commented 8 years ago

Please consider an "event ID" to be a major internal meta datum of any recording. It's something that exists, has a meaning and can be super helpful when being search for, referenced etc. The basic iead for the Pentabard Event ID was to be public and highly visible, not an internal and exchangeable reference code hidden from the user.

derpeter commented 8 years ago

I would agree on that. For all events where we still got the schedule this could possibly updated more or less automatically. Even if the ID is no unique over all conferences and not all conference have that flag it would by very help full for things where the i.e. the name is not known. At least we could consider adding it to the tags what would be not that helpfull and hart to do for the already released stuff but better then nothing.

@timpritlove do you think we could get some of your follwers minions to help a little with media. Pull request are highly appriciated

saerdnaer commented 8 years ago

TODO: add slug to https://github.com/voc/voctoweb/blob/master/app/models/concerns/elasticsearch_event.rb#L15

saerdnaer commented 8 years ago

Looks like we missed the correct option: https://media.ccc.de/search/?q=7551

MaZderMind commented 8 years ago

Well we added the field to the search but missed the serializer. fix incoming.