Closed rhine3 closed 1 year ago
Hi @rhine3 thank you for catching this.
Could you say a little more about how you installed crowsetta
?
Did you run pip install crowsetta
or conda install crowsetta -c conda-forge
?
Or did you install the development code directly into the environment, e.g. with pip install -e .
?
If you installed of a package manager, then I think what might be going on is that you have a previous release, that does not include changes I made on the main branch.
Could you please try setting up a development environment as described here and then try running the tests with nox
? (nox -s tests
)
Please let me know if you still get the same error then.
I'm not sure what else could cause it besides installing from a package manager. I can see the CI is passing on main and I do not get this error when I run tests locally.
you may want to update the sample issue text here to say "You can determine this in Python by importing crowsetta and running crowsetta.__version__"
Thank you, this is a good idea, I will add it to the issue template
Hi @NickleDave!
Long story short, you're right that I hadn't tried installing the development environment. I was just testing crowsetta
directly from within the tests folder within an Anaconda environment that had crowsetta
installed.
(I can't remember if the environment I was working with had crowsetta
installed via pip
or conda
; I tried both of them in separate environments to verify they both worked.)
Once I actually got the development environment installed, all tests succeeded, except the command I had to run to activate the environment was . ./.venv/bin/activate
(the documentation says to use the command . ./.venv/activate
.
I did get one warning when running the tests:
../src/crowsetta/_vendor/textgrid/textgrid.py:562
/Users/tessa/Downloads/crowsetta_review/crowsetta/src/crowsetta/_vendor/textgrid/textgrid.py:562: DeprecationWarning: invalid escape sequence \w
m = re.match('File type = "([\w ]+)"', header)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
Fixed the snippet that shows how to print crowsetta.__version__
in 58bb6f1
Made strings for regex raw to fix DeprecationWarning, in aca85f1
@all-contributors please add @rhine3 for doc and bug
@NickleDave
I've put up a pull request to add @rhine3! :tada:
Closing this
@all-contributors please also add @rhine3 for userTesting ideas
@NickleDave
I've put up a pull request to add @rhine3! :tada:
Before submitting a bug, please make sure the issue hasn't been already addressed by searching through the past issues
Describe the bug While running tests with Pytest I found that 6 of the tests in
test_formats/test_seq/test_generic.py
failed on my machine. The short test summary info is below; longer test summaries are copied at the end of this issue.To Reproduce I cloned the GitHub repository on my local machine. I installed
crowsetta
in a Python 3.10.9 Anaconda environment and also conda installedpytest
. I navigated to thetests
directory and ran the commandpytest *
.Expected behavior I expected the tests to pass! :)
Screenshots Errors are reproduced in text below instead
Desktop (please complete the following information):
vak.__version__
- Mycrowsetta
version is '4.0.0.post2'; by the way, you may want to update the sample issue text here to say "You can determine this in Python by importingcrowsetta
and runningcrowsetta.__version__
"Additional context I created this issue while performing the PyOpenSci review of this package. Full text of tests is reproduced below.