vocascan / vocascan-frontend

A highly configurable vocabulary trainer
https://vocascan.com
Apache License 2.0
30 stars 8 forks source link

Search Entries in the Packages #108

Open engahmadkadi opened 2 years ago

engahmadkadi commented 2 years ago

As a user of vocascan-fronend, I wish to have the possibility to search the entries of the packages I have entered in my account. This would ease the continuous enhancement of own vocabularies, for example to see if the entry is already entered, or to follow a previous example.

The search should be possible on the page (or level) of packages, and inside by at the separated packages. This give the user to chance to filter the search, either in all the packages, or in specific on

The result should be clickable, i.e. show the editing page, as it is now in browsing the entries of a package.

engahmadkadi commented 2 years ago

Related discussion #104

luwol03 commented 2 years ago

I can imagine the search functionality something like this to easily search vocabularies. Unbenannt

However I can also think of an advanced search mechanism which is able to also filter for well learned cards or newly added one. For this maybe we could add a tab or add some option to apply filters on the search.

What do you think?

noctera commented 2 years ago

for example to see if the entry is already entered

In addition to that we have already planned to implement a warning, as @luwol03 had already said in #104. That would look something like this.

image

engahmadkadi commented 2 years ago

I can imagine the search functionality something like this to easily search vocabularies.

This is already doing it, in my opinion. So this on the level of package, right?

However I can also think of a advanced search mechanism which is able to also filter for well learned cards or newly added one. For this maybe we could add a tab or add some option to apply filters on the search.

What do you think?

What else you want to add, would be the icing on the cake :)

luwol03 commented 2 years ago

This is already doing it, in my opinion. So this on the level of package, right?

In my painting it was on vocabulary level. For implementing it on the different pages I have no clue, because it doesn't helps if I get all packages in which are vocabularies that matches the search term.

So this search should apply to all tables but not searches deeply (no vocabularies in packages, only through the names of all packages if you are on the packages table, only all groups if you are on the groups table and same for vocabs.)

And then the advance search could do the trick of searching for vocabularies without knowing in which package they are located.

Tracer1337 commented 2 years ago

I'm working on it

luwol03 commented 2 years ago

This feature is now implemented in the backend so only the frontend now needs some adjustments. Thank you @Tracer1337 for your contribution.

Tracer1337 commented 2 years ago

The Frontend PR is merged as well. This Issue can be closed now

luwol03 commented 2 years ago

We can. The suggested advanced search and the notice that such an vocab already exists will be tracked in a board?

Tracer1337 commented 2 years ago

The advanced search should be put on the board, I guess we have other Tickets that are more important to do first.

The "vocab already exists" notice is not specifically requested by this issue, so we can leave it out (or make a ticket, if you like)

This would ease the continuous enhancement of own vocabularies, for example to see if the entry is already entered, or to follow a previous example.

luwol03 commented 2 years ago

I think we keep it open, because search on package level is also requested (which could be imagined like the advanced search)