search

vocascan / vocascan-frontend

A highly configurable vocabulary trainer
https://vocascan.com
Apache License 2.0
30 stars 8 forks source link

Fixed dark mode bug #139

Closed aritroCoder closed 2 years ago

aritroCoder commented 2 years ago
Status Type
:white_check_mark: Ready Bug

Description Fixed the bug by changing the SCSS color variable used

Motivation and Context Now the nav header is visible in dark mode

Screenshots / GIFs (if appropriate): Screenshot from 2022-09-29 17-19-52

Checklist [x]I have read the CONTRIBUTING document. [x]I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?) [x]I have documented my code if needed Resolves issue https://github.com/vocascan/vocascan-frontend/issues/130

noctera commented 2 years ago

@aritroCoder Now you deleted the whole package-lock.json. You only had to revert your own changes in it.

Could you please fix this, so you don't have any modifications in the package-lock.json?

aritroCoder commented 2 years ago

I think its done now

Tracer1337 commented 2 years ago

Please also provide a screenshot of how the changes affect the dark-theme. If both look good, this can be merged

aritroCoder commented 2 years ago

Please also provide a screenshot of how the changes affect the dark-theme. If both look good, this can be merged

image

noctera commented 2 years ago

Looks good to me. This can be merged