search

vocatwk / CodeU-Nemo

Chat web app for CodeU
Apache License 2.0
1 stars 3 forks source link

Allow users to create conversations with multi-word titles #100

Closed vocatwk closed 6 years ago

vocatwk commented 6 years ago

resolves #85

I encode spaces in the conversation title with "-" when stored in the conversation class. I replace them back with a space during display. I was going to do it the other way(replace the spaces with "-" when sending requests and putting them back after) but I thought this way would be easier and less riskier.

Also, I noticed we don't clean conversation titles for html like we do messages, is there a reason for that or should we add it?

EDIT

I switched to using UUIDs for the urls, I updated the tests and the Event information as well as removed some restrictions.

yebrahim commented 6 years ago

As far as I can see, the only reason why we use alphanumeric titles is because we're using it as an identifier for the conversation, and in the URL, which I don't think is a good idea. Since we have a UUID for each conversation anyway, how about we switch to using this in the URL and to load the conversation, then we can just store free form titles with no restrictions? (Not even unique)

vocatwk commented 6 years ago

Oh that does sound like a much better idea, I'll change it to using UUID

lealgamb commented 6 years ago

I like the idea of using UUID. Also, I'm in favor of cleaning any html content.