search

vocatwk / CodeU-Nemo

Chat web app for CodeU
Apache License 2.0
1 stars 3 forks source link

Subscribe protoype #90

Closed jasminechau2 closed 6 years ago

jasminechau2 commented 6 years ago

This is a basic idea of getting the subscriptions I still need to implement css and make the subscriptions on the same page as the notifications

yebrahim commented 6 years ago

An alternative approach here is to add a subscriptions list field in the User class, and make a PUT request to /profile to add to the list. This will be simpler than implementing a different servlet for it, along with its tests. :)

jasminechau2 commented 6 years ago

I didn't think to do that thank you for the tip!

jasminechau2 commented 6 years ago

Yup

yebrahim commented 6 years ago

Is this PR blocked on anything?

jasminechau2 commented 6 years ago

I was just focusing on the notification testing I can start pushing commits today

yebrahim commented 6 years ago

Is this ready for review?

jasminechau2 commented 6 years ago

no not yet

lealgamb commented 6 years ago

LGTM 👍 . I know that our project really only allows us to subscribe to notifications. If we had more time it would be cool to receive notifications when users sign in.

jasminechau2 commented 6 years ago

Good catch thank you @vocatwk

jasminechau2 commented 6 years ago

can I merge this?