vocdoni / census3

Golang library and a HTTP/API service that can be used to fetch an updated list of token holders for a Ethereum ERC20, ERC721, ERC777, or other external providers (ex. POAPs or GitcoinPassport).
GNU Affero General Public License v3.0
9 stars 2 forks source link

include full name in every stamp instead of use the externalID #183

Closed lucasmenendez closed 8 months ago

lucasmenendez commented 8 months ago

solving #182

Summary by CodeRabbit

github-actions[bot] commented 8 months ago

Image description CodeRabbit

Walkthrough

The changes introduced in this pull request primarily focus on enhancing the readability of the GitcoinPassport struct. The Name function now returns full names for given stamps, utilizing a new map stampsNames. This update does not alter the core functionality or logic of the code.

Changes

Files Summary
scanner/providers/gitcoin/gitcoin_provider.go, scanner/providers/gitcoin/gitcoin_stamps.go The Name function in the GitcoinPassport struct has been updated to return full names corresponding to given stamps. A new map stampsNames is introduced for this purpose.

🐇💻

In the land of code, where the shadows lie,

A rabbit hopped forth, with a twinkle in its eye.

With each key press, a change was made,

Enhancing readability, in the compiler's shade.

No logic altered, no function swayed,

Just a simple tweak, in the map relayed.

So here's to the coder, with their skill so bright,

Making code clearer, in the soft moonlight. 🌙✨


Uplevel your code reviews with CodeRabbit Pro ### CodeRabbit Pro If you like this project, please support us by purchasing the [Pro version](https://coderabbit.ai). The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.