Final Bug Compilation

[jpaulet]

Generic Bugs:

• [x] You can create a dao and set approval days to 0, no error is shown and Next button is activated

• [x] Members component is showing multisig members and not token holders.

• [x] Use existing mintable token does not read properly the token amount (Subgraph issue)

• [x] Created a DAO importing a existing token, and the "DAO Members" page is empty (at the beggining I though it will be bc the token is still being scanned, but after 30 min, nothing has changed). After a while, only 1 token holder appears ("you"). Then it disappears and 0 members is show again... It happens every time I click the "Members page" from the "Tokenholders" link or the header. DAO: https://ipfs.eth.aragon.network/ipfs/QmfYKEhRe3GJUiSqMuqTQC2Cb21LpkQ2kXhu4bkb3L2mXk/#/daos/goerli/mnktest.dao.eth/dashboard

• [x] Also, when clicking into the "Dashboard", the Members component appears and disappears.

• [x] In the "Create DAO - Review DAO" step, the "Early execution" and "Vote Change" shouldn't appear (or at least appear as "No"). Also, make sure that the 2 parameters are set to "no" in all cases. Same in "Settings" page.

• [x] In the "Edit Settings" page, the "Governance" tab is empty:

Vote page:

• [x] In the "Actions approval" -> "Info" tab, when 0 approvals are set, the label/texts says "Reached" - "No approvals missing", instead of "Pending" or "Not started" or similar:

• [x] Due to small differences between the end of process onchain and offchain this error message may appear to the user. It should be caught (ideally from an vocdoni SDK typed error) and printed better

• [x] We should differentiate or improve and review all the labels with time in the proposals, as now it get mixed the "Voting" time with the "Approve and Execute" time, resulting in confusing messages:

I.E - The vote text shows "Ends in 34 min" when it should be "Ended in 34 min."

• [x] Review timestamp on active proposal card

Translations:

• [x] Missing Translations:
  • Settings Page: navLinks.executionMultisig
  • Settings Page: labels.review.members

Proposal Creation Bugs:

• [x] Cannot create proposal. Errors:

  • 0 Undefined:

  • Token error:

    • Account does not exist:

• Wallet already funded:

[selankon]

In the "Create DAO - Review DAO" step, the "Early execution" and "Vote Change" shouldn't appear (or at least appear as "No"). Also, make sure that the 2 parameters are set to "no" in all cases. Same in "Settings" page.

I hide it after https://github.com/aragon/app/commit/ce747c43 and i double check that this attributes are not sent to aur plugin settings object so we can just hide it and ignore the form default values (where early execution is set to true by default)

[selankon]

To review

Missing nº of approvals needed in the "Settings page" (x of 1 authorized addresses -> "x" is missing)

It seems the actual string is wrong https://github.com/aragon/app/blob/378bee04cfe5c42d47f91578e551a7a6acefa4fb/src/locales/en/common.json#L175

When updated remember to update also the review create dao https://github.com/aragon/app/blob/378bee04cfe5c42d47f91578e551a7a6acefa4fb/src/containers/goLive/committee.tsx#L100

The charts in the voting page, seems to not be right when adding "Abstain" votes:

It seems an error on the percentage calculation, where the abstained votes are not counted on the total of votes. https://github.com/aragon/app/blob/ee75ef1162958e59e093bb64195cc54b8ee51888/src/utils/proposals.ts#L256

[selankon]

Missing translations

• [x] Settings Page: navLinks.executionMultisig
• [x] Settings Page: labels.review.members

Both fixed on the f/gasless-propose-settings branch

[selankon]

In the "Edit Settings" page, the "Governance" tab is empty:

Fixed on the f/gasless-propose-settings branch

[selankon]

In the "Actions approval" -> "Info" tab, when 0 approvals are set, the label/texts says "Reached" - "No approvals missing", instead of "Pending" or "Not started" or similar:

Should be fixed on

https://github.com/aragon/app/commit/ee75ef11

[selankon]

To review

Created a DAO importing a existing token, and the "DAO Members" page is empty (at the beggining I though it will be bc the token is still being scanned, but after 30 min, nothing has changed). After a while, only 1 token holder appears ("you"). Then it disappears and 0 members is show again... It happens every time I click the "Members page" from the "Tokenholders" link or the header. DAO: https://ipfs.eth.aragon.network/ipfs/QmfYKEhRe3GJUiSqMuqTQC2Cb21LpkQ2kXhu4bkb3L2mXk/#/daos/goerli/mnktest.dao.eth/dashboard Also, when clicking into the "Dashboard", the Members component appears and disappears.

EDIT FIXED: it was a subgraph issue

OLD:

I cannot reproduce it, on my localhost branch everything works as expected. Two members appear.

BTW, the token holders members are shown using a third party library afair. So if the token holders are not scanned properly is probably an issue with this library. Let me know if i have to look deeper on it, for the moment i marked the issues as resolved.

EDIT: for a previously already minted token with the Aragon app, it don't show the amount of tokens every wallet has. Not sure if this is a Aragon error or what.

I set the issue as pending

https://goerli.etherscan.io//token/tokenholderchart/0x61ba9dc4520635e220cb4ed46ea601a8040c3685 http://localhost:3000/#/daos/goerli/3tokenholdersaddremove.dao.eth/community

[selankon]

Review timestamp on active proposal card

https://github.com/aragon/app/commit/d3e15c8c

[selankon]

You can create a dao and set approval days to 0, no error is shown and Next button is activated

https://github.com/aragon/app/commit/49073ccc

Due to small differences between the end of process onchain and offchain this error message may appear to the user. It should be caught (ideally from an vocdoni SDK typed error) and printed better

https://github.com/aragon/app/commit/d33b9735

We should differentiate or improve and review all the labels with time in the proposals, as now it get mixed the "Voting" time with the "Approve and Execute" time, resulting in confusing messages:

This should be fixed somewhere. I corrected a bug some commits ago that fixes how the time is calculated.

[jpaulet]

• [x] New visual bug on the Dashboard, when 1 token-holder, the list is not rendered properly:

Edit

This is an Aragon issue