Issues found while trying to register a new account on the current SaaS implementation

[elboletaire]

I was trying to create a new account and found some issues while trying to do so. Everything I've tried was done via the UI, so these errors can be either from back-end flow issues, or wrong implementations by the front-end:

1. Trying to register an account with existing data returns internal server error.
2. The "last verification code still valid" error doesn't sound good. The normal behavior is to create a new verification code and send that instead.
3. After discovering I could have a button to verify my account under the development environment, apparently it was too late and my verification code already expired (we're talking about a 5' delay maybe, but since I tried registering the account again and got that internal server error... maybe it's related).
4. There's no way to verify an account under develop after 5' (?)
5. Trying to login with a non existent account returns "user not authorized", which doesn't sound as a proper error message for this use case.
6. Can't logout from my logged in account if I've not created any org yet. The logout button should be more visible... it's down below the form, after the "if this is not your account, please logout". That "please logout" should also be a logout button.
7. The organization creation form shows a confusing error at the bottom: "Account not found: 0x834DE..." where 0x834DE... is my currently logged in wallet 🤔
8. From the "organization type" most types aren't implemented in the backend. The front-end should not be rendering unimplemented options.
9. When submitting the organization information, a metamask sign request to create my SIK is generated. Probably caused by running it locally on the same port I run most applications (and having a metamask session started in this same domain:port). After cancelling the sign request, a "user rejected transaction" error appeared, staying me on the "create organization" form. Login-out and login-in again apparently shows my organization created though.

(edited to include numeric indexes)

[lucasmenendez]

• Topics 1 & 3: now the registration endpoint returns a 409 Conflict error with body (see the docs):

  {
  "error": "duplicate conflict: user already exists",
  "code": 40901
  }

• Topics 2 & 4: the verification codes have an expiration time of 2 minutes. After this time, the expiration code is not valid and must be sent again. To manage this flow, there are two endpoints available, one to check the information about a verification code by the email, and another to resend a verification code to an unverified user.

• Topics 5 & 7: I suggest not to show the errors that coming from the API directly in the UI, I think it is better to handle them and show specific messages to the users. The errors returned by the API may not be meaningful to the end user. If the UI needs more specific errors for some use cases, they can be implemented in the backend.

• Topic 8: as far as i know there is no single source of truth for organization types. For now, the backend has two types (company & community). I already suggested that they should be defined in the backend (where the validation of this data is done) and exposed in an API endpoint (if it is needed). And the same for the user roles (now admin, manager and viewer).

I do not answer to other topics because I think that there are no a backend issues.

cc/ @elboletaire @jpaulet