search

vocdoni / ui-components

Vocdoni UI components libs
GNU General Public License v3.0
3 stars 2 forks source link

Review Wallet vs Signer flows #120

Open nigeon opened 9 months ago

nigeon commented 9 months ago

When logged in using OAuth (oauth walet), voting page asks for a signature and when clicked it lets you vote without any input (probably a modal should be shown).

Refreshing the page doesn't recognize you and lets you vote again, even though looks like the vote will be overwritten (if possible).

elboletaire commented 9 months ago

I rename the issue to also track other possible Wallet flows that need review, like adding a ConfirmModal for Actions when the logged in account is a Wallet instead of a Signer (since signers will have to manually confirm the sign of a transaction, while Wallets do it in the background, making it silent for the end-user).

elboletaire commented 7 months ago

Set on hold since there's nothing that can be done here, at least not that we can think of.

The conditions are properly set here, the issues arise when using rainbowkit v2 (using wagmi/viem), since you need to convert ethers wallets to signers using an adapter, but ui-components are totally unaware of the wallet library used... the only fixes we could think of were altering the wallet object, but such alteration would require it to be always done by the end developers...