vocdoni / ui-components

Vocdoni UI components libs
GNU General Public License v3.0
3 stars 2 forks source link

Post PxLL: add confirmation modal #156

Closed selankon closed 4 months ago

selankon commented 5 months ago

After the PxLl voting process, we should solve & improve some issues:

Related to https://github.com/vocdoni/ui-components/issues/153 (because come from PxLL feedback)

selankon commented 5 months ago

After talk with @elboletaire we found that the ui-scaffold is not using the buttons to execute the actions of the chakra-ui components:

The chakra ui action button:

https://github.com/vocdoni/ui-components/blob/main/packages/react-providers/src/election/ActionsProvider.tsx#L51 https://github.com/vocdoni/ui-components/blob/main/packages/chakra-components/src/components/Election/Actions/Pause.tsx#L7

The ui scaffold action button:

https://github.com/vocdoni/ui-scaffold/blob/0988c92326ea3b0f4f5511f542ad3c15828c8857/src/components/Process/ActionsMenu.tsx#L48-L64

So the first thing is to try to implement the chakra-component button on the ui scaffold and then implement the confirmation modal here on the ui components.

Here an example of how to do it:

https://github.com/vocdoni/ui-components/blob/main/packages/chakra-components/src/components/Election/Questions.tsx#L36