vocdoni / ui-components

Vocdoni UI components libs
GNU General Public License v3.0
3 stars 2 forks source link

Review what's being bundled in rainbowkit-wallets #185

Open elboletaire opened 2 months ago

elboletaire commented 2 months ago

React is being bundled, among other dependencies that could be added as peer dependencies and imported by the end developer.

Trying to remove it by adding it to peer dependencies causes the final bundle to fail, since it tries to import react dynamically and it simply crashes. The react-modal package used may be doing something wrong, and changing it to a chakra-ui/modal may be required to properly ignore react in the final bundle.