search

vocdoni / ui-components

Vocdoni UI components libs
GNU General Public License v3.0
3 stars 2 forks source link

Allow setting custom URLs to clients #87

Closed selankon closed 10 months ago

selankon commented 1 year ago

The census 3 have an attribute called api-url to point the census3 service, which on the react providers, cannot be changed.

elboletaire commented 1 year ago

I think this should be a more generic issue, and also ensure setting custom urls in the client works. Right now I'm pretty sure it won't work in some scenarios, and should be checked and fixed.

I'm changing the title.

elboletaire commented 1 year ago

Due to how the env and api_url settings work, there's a clash in some scenarios that could be resolved by storing the first defined api_url via the provider (when a client is specified, ofc). But after speaking with Marc, we considered this can wait until the SDK refactoring of this part (see vocdoni/vocdoni-sdk/issues/243), since it should not be required to do magical stuff with the env and urls after such refactoring is done.

elboletaire commented 11 months ago

closed by #118

elboletaire commented 11 months ago

Dang, we did forgot about the census3 options 🤦🏼