search

vocdoni / ui-scaffold

Vocdoni's protocol UI
https://app.vocdoni.io
GNU Affero General Public License v3.0
5 stars 2 forks source link

Delete CSP Election creation duplicated code #700

Closed selankon closed 4 months ago

selankon commented 5 months ago

This code seems to be duplicated, need to be tested

github-actions[bot] commented 5 months ago

🚀 Deployed on https://66696eda847531a0519ad2de--vocdoni-app-dev.netlify.app

github-actions[bot] commented 5 months ago

🚀 Deployed on https://66696edb51fdd09e40c73bba--onvote-stg.netlify.app

github-actions[bot] commented 5 months ago

🚀 Deployed on https://66696ed651fdd09e40c73bb5--vocdoni-app-stg.netlify.app

elboletaire commented 4 months ago

Ok so based on the actual commit where this was done (check the commit title and description): https://github.com/vocdoni/ui-scaffold/commit/b6166a224694b66b423ae890018674161881ee07

And after speaking with Aleix, I think this was a special case where the census had to be created before the process creation.

This functionality looks broken anyways, because at some point we changed that pid != step.processID with a step.key === ElectionCreationSteps.DONE, so if it was creating the census before the process, it's probably failing here in this point now.

I'd say what I already said... let's accept the PR and try to fix this properly when we need the CSP again, since it looks broken already.