search

vocdoni / ui-scaffold

Vocdoni's protocol UI
https://app.vocdoni.io
GNU Affero General Public License v3.0
5 stars 2 forks source link

Add mail verification code form #778

Closed selankon closed 4 weeks ago

selankon commented 1 month ago

It adds an input text to the mail verification page to copy paste the code if the user wants to do it (instead of follow the direct link sent on the email)

github-actions[bot] commented 1 month ago

🚀 Deployed on https://66fd1a0ecdb31fb2992c0e10--vocdoni-app-dev.netlify.app

github-actions[bot] commented 1 month ago

🚀 Deployed on https://66fd1a0d764d00b495d6042a--vocdoni-app-stg.netlify.app

emmdim commented 1 month ago

@selankon while technicaclly this PR is ok, from a UX perspective the fact that if you insert a wrong go then you are redirected to a new Error page and pressing the back button leads you to the inital page is problematic.

2024-10-01-165746_875x479_scrot

I would suggest to show an error in the same page that asks for the verification code, and then allowing the user to inout the code again. cc @jpaulet

jpaulet commented 1 month ago

@selankon while technicaclly this PR is ok, from a UX perspective the fact that if you insert a wrong go then you are redirected to a new Error page and pressing the back button leads you to the inital page is problematic.

2024-10-01-165746_875x479_scrot

I would suggest to show an error in the same page that asks for the verification code, and then allowing the user to inout the code again. cc @jpaulet

Yes, the error should go in the same page, with the instructions to re-check the code and input it again, or a new button to ask a new code, as commented by Manos.

selankon commented 4 weeks ago

Totally agree. I also created a component VerifyForm to store the verify form logic sepparatelly