Enable empty startTime, disable past startTime

vocdoni / vaas-api

Centralized backend & server for Vocdoni's Voting-as-a-Service API

GNU Affero General Public License v3.0

2 stars 1 forks source link

Enable empty startTime, disable past startTime #26

Closed NateWilliams2 closed 2 years ago

p4u commented 2 years ago

This https://github.com/vocdoni/vocdoni-node/pull/420 introduces the possibility to set startBlock:=0 in order to start the process on the next block where the newProcess transaction is included. Maybe it could modify some behavior of this PR?

NateWilliams2 commented 2 years ago

Maybe it could modify some behavior of this PR?

The current behavior is

if startDate is empty, set startBlock to 0 and start the process asap
if startDate is not empty, ensure it is in the future. If not, return an error

@p4u Would you propose startBlock to be set to 0 in the second scenario, rather than returning an error?

p4u commented 2 years ago

~~Yes~~

No. If startDate is set it means the caller wants to enforce this startBlock, so if not in the future it should be invalid