vocdoni / vaas-api

Centralized backend & server for Vocdoni's Voting-as-a-Service API
GNU Affero General Public License v3.0
2 stars 1 forks source link

Integration test #33

Closed NateWilliams2 closed 2 years ago

NateWilliams2 commented 2 years ago

So far this PR sets up an integration test suite with a Vocone instance and a CSP running. It then starts a VaaS API server connected to these services.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1708890056


Changes Missing Coverage Covered Lines Changed/Added Lines %
urlapi/superadmin.go 6 8 75.0%
test/testcommon/apis.go 23 27 85.19%
test/testcommon/util.go 54 59 91.53%
urlapi/util.go 28 37 75.68%
test/testcommon/services.go 33 49 67.35%
<!-- Total: 152 188 80.85% -->
Totals Coverage Status
Change from base Build 1689541445: 47.8%
Covered Lines: 1774
Relevant Lines: 3202

💛 - Coveralls
NateWilliams2 commented 2 years ago

@mvdan

starting the services we need directly via the Go API seems fine to me

do you mean running a go execution of a command to start up a vocone and a CSP in other processes? If so, that's a good point. I'll try to do that.

mvdan commented 2 years ago

do you mean running a go execution of a command to start up a vocone and a CSP in other processes? If so, that's a good point. I'll try to do that.

Oh, I meant the opposite, that doing it in-process like you're doing now seems fine :P Using separate processes could also work, if it helps for one reason or another. Note that you would lose the code coverage from them though. Debugging could also get a bit harder, as you'd now juggle multiple processes.

NateWilliams2 commented 2 years ago

@mvdan

Oh, I meant the opposite, that doing it in-process like you're doing now seems fine :P

Ok wonderful :)