Closed NateWilliams2 closed 2 years ago
@jordipainan the CI is failing because there's a race on the vocone methods for SetTreasurer, MintTokens, SetTxCost, and setBulkTxCost, when these methods run app.State.Save()
to save the changes to the state. This races with the main vochain goroutine.
I would say we can get around this by sending the transactions to do these things to the vocone API in testing, but I don't think we have a way to set the treasurer public key in that case. Do you know of a solution?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
test/testcommon/apis.go | 5 | 7 | 71.43% | ||
test/testcommon/services.go | 11 | 17 | 64.71% | ||
cmd/vaasapi/vaasapi.go | 0 | 8 | 0.0% | ||
urlapi/entity.go | 20 | 39 | 51.28% | ||
vocclient/vocclient.go | 19 | 85 | 22.35% | ||
<!-- | Total: | 58 | 159 | 36.48% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
urlapi/public.go | 2 | 56.36% | ||
vocclient/vocclient.go | 2 | 44.37% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 1983255489: | -1.1% |
Covered Lines: | 1979 |
Relevant Lines: | 3599 |
sorry nate I missed this, but already commented on sync meeting, the locks are merged to the master branch :)
PR LGTM ! We can go ahead ^^
This PR has three main changes: