Update Vocdoni-node - ethless

NateWilliams2 commented 2 years ago

This PR has three main changes:

use the new vocdoni-node signing methods
check & use account nonces for vochain transactions
collect tokens from faucet when creating a new account

NateWilliams2 commented 2 years ago

@jordipainan the CI is failing because there's a race on the vocone methods for SetTreasurer, MintTokens, SetTxCost, and setBulkTxCost, when these methods run app.State.Save() to save the changes to the state. This races with the main vochain goroutine.

I would say we can get around this by sending the transactions to do these things to the vocone API in testing, but I don't think we have a way to set the treasurer public key in that case. Do you know of a solution?

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2077957497

58 of 159 (36.48%) changed or added relevant lines in 6 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.1%) to 54.987%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
test/testcommon/apis.go	5	7	71.43%
test/testcommon/services.go	11	17	64.71%
cmd/vaasapi/vaasapi.go	0	8	0.0%
urlapi/entity.go	20	39	51.28%
vocclient/vocclient.go	19	85	22.35%
<!--	Total:	58	159	36.48%	-->

Files with Coverage Reduction	New Missed Lines	%
urlapi/public.go	2	56.36%
vocclient/vocclient.go	2	44.37%
<!--	Total:	4	-->

Totals
Change from base Build 1983255489:	-1.1%
Covered Lines:	1979
Relevant Lines:	3599

💛 - Coveralls

jordipainan commented 2 years ago

sorry nate I missed this, but already commented on sync meeting, the locks are merged to the master branch :)

jordipainan commented 2 years ago

PR LGTM ! We can go ahead ^^

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 2077957497

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

58 of 159 (36.48%) changed or added relevant lines in 6 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.1%) to 54.987%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
test/testcommon/apis.go	5	7	71.43%
test/testcommon/services.go	11	17	64.71%
cmd/vaasapi/vaasapi.go	0	8	0.0%
urlapi/entity.go	20	39	51.28%
vocclient/vocclient.go	19	85	22.35%
<!--	Total:	58	159	36.48%	-->

Files with Coverage Reduction	New Missed Lines	%
urlapi/public.go	2	56.36%
vocclient/vocclient.go	2	44.37%
<!--	Total:	4	-->

Totals
Change from base Build 1983255489:	-1.1%
Covered Lines:	1979
Relevant Lines:	3599

vocdoni / vaas-api