refactor genesis package - Githubissues

vocdoni / vocdoni-node

A set of libraries and tools for the Vocdoni decentralized backend infrastructure, the main ground of our universally verifiable, privacy-centric and scalable digital voting protocol

GNU Affero General Public License v3.0

82 stars 16 forks source link

refactor genesis package #1310

Closed altergui closed 3 weeks ago

altergui commented 1 month ago

roadmap towards being able to create a chain "on top" of another chain:

current ChainID vocdoni/LTS/1.2
future ChainID vocdoni/LTS/1.3
genesis for vocdoni/LTS/1.2:
- InitialHeight: 0
- AppHash: a910efa67b8ea3cfbbf57fd6a9e3be6e52e3769c29fd30b3272a26224c4a1b05 (virgin state)
- Validators: GenesisValidatorsFrom(genesis.AppStateValidators)
- AppState: {accounts, txcosts, etc}

create a "fork" on block 2000000 (miners will stop vocdoni/LTS/1.2 at that height)

genesis for vocdoni/LTS/1.3:
- InitialHeight: 2000001
- AppHash: cafecafe...(the actual AppHash of vocdoni/LTS/1.2 at height 2000000)
- Validators: GenesisValidatorsFromState(app.State)
- AppState: {} or {txcosts} or whatever
this needs a nice refactor of the genesis package
- undo most of the wrapping of current genesis package, use comet genesis types directly (wdyt @p4u? there's a comment from you)
```
// The genesis app state types are copied from
// github.com/cometbft/cometbft/types, for the sake of making this package
// lightweight and not have it import heavy indirect dependencies like grpc or
// crypto/*.
```
  but i think that's outdated since there's anyway a import github.com/cometbft/cometbft/types

altergui commented 1 month ago

notably, i'm also moving the AutoUpdateGenesis concept out of genesis.go, and turn this into a flag, since i believe this should be handled via env vars on each deployment