api: refactor pagination (WIP)

vocdoni / vocdoni-node

A set of libraries and tools for the Vocdoni decentralized backend infrastructure, the main ground of our universally verifiable, privacy-centric and scalable digital voting protocol

GNU Affero General Public License v3.0

82 stars 16 forks source link

api: refactor pagination (WIP) #1341

Open altergui opened 1 week ago

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9562662039

Details

8 of 24 (33.33%) changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 61.294%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
httprouter/message.go	0	3	0.0%
api/elections.go	8	21	38.1%
<!--	Total:	8	24	33.33%	-->

Files with Coverage Reduction	New Missed Lines	%
vochain/indexer/indexer.go	2	68.58%
<!--	Total:	2		-->

Totals
Change from base Build 9546446432:	-0.01%
Covered Lines:	15920
Relevant Lines:	25973

Pull Request Test Coverage Report for Build 9564087996

Details

34 of 41 (82.93%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 61.43%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/elections.go	20	27	74.07%
<!--	Total:	34	41	82.93%	-->

Totals
Change from base Build 9546446432:	0.1%
Covered Lines:	15957
Relevant Lines:	25976

Pull Request Test Coverage Report for Build 9579304909

Details

55 of 72 (76.39%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 61.401%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
vochain/indexer/process.go	10	14	71.43%
api/accounts.go	1	6	16.67%
api/elections.go	23	31	74.19%
<!--	Total:	55	72	76.39%	-->

Totals
Change from base Build 9578771142:	0.1%
Covered Lines:	15955
Relevant Lines:	25985

Pull Request Test Coverage Report for Build 9580078879

Details

55 of 72 (76.39%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 61.416%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
vochain/indexer/process.go	10	14	71.43%
api/accounts.go	1	6	16.67%
api/elections.go	23	31	74.19%
<!--	Total:	55	72	76.39%	-->

Totals
Change from base Build 9578771142:	0.1%
Covered Lines:	15959
Relevant Lines:	25985

this PR is far from finished but since the road ahead is just repeating what i did for /elections to the rest of the endpoints, i'd really appreciate some early feedback on the approach taken so far, particularly from @mvdan on the indexer part

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9581805081

Details

79 of 100 (79.0%) changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 61.439%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
vochain/indexer/process.go	10	14	71.43%
api/elections.go	26	33	78.79%
api/accounts.go	21	31	67.74%
<!--	Total:	79	100	79.0%	-->

Files with Coverage Reduction	New Missed Lines	%
api/elections.go	1	58.63%
<!--	Total:	1		-->

Totals
Change from base Build 9578771142:	0.2%
Covered Lines:	15976
Relevant Lines:	26003

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9605211222

Details

152 of 187 (81.28%) changed or added relevant lines in 9 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.3%) to 61.644%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/helpers.go	16	18	88.89%
vochain/indexer/indexer.go	11	13	84.62%
vochain/indexer/process.go	11	14	78.57%
api/accounts.go	33	39	84.62%
api/elections.go	51	73	69.86%
<!--	Total:	152	187	81.28%	-->

Files with Coverage Reduction	New Missed Lines	%
api/elections.go	1	62.74%
vochain/indexer/indexer.go	2	68.04%
<!--	Total:	3	-->

Totals
Change from base Build 9595822141:	0.3%
Covered Lines:	16107
Relevant Lines:	26129