vocdoni / vocdoni-sdk

Vocdoni SDK for API
GNU Affero General Public License v3.0
13 stars 6 forks source link

Blakejs should be a normal dependency #418

Closed elboletaire closed 1 month ago

elboletaire commented 1 month ago

I'm not sure why this dependency wasn't added as a normal dependency, but with recent integrations we found it out, since having it as a devDependency causes projects using the github reference in package.json to not install dev dependencies, thus causing errors because they cannot find blakejs.

Set as draft while I give it a try on some integrations, using the current branch.

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
dist/index.js 44.57 KB (0%)
dist/index.mjs 43.86 KB (0%)
dist/index.umd.js 45.32 KB (0%)
elboletaire commented 1 month ago

Seems to be working well in integrations now, setting ready to review.